bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: in dired hit v on a .zip archive


From: Kevin Rodgers
Subject: Re: in dired hit v on a .zip archive
Date: Fri, 9 Apr 2004 16:01:51 -0600
User-agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:0.9.4.1) Gecko/20020406 Netscape6/6.2.2

Dan Jacobson wrote:
> In dired hit v on a .zip archive.
> Now both view mode and zip-archive mode are in effect.
> I say only zip-archive mode should be now in effect, just as if we hit RET.

I say Emacs is behaving correctly and as documented:

| v runs the command dired-view-file
|    which is an interactive compiled Lisp function in `dired'.
| (dired-view-file)
|
| In dired, examine a file in view mode, returning to dired when done.

> Just as when we hit v on a subdirectory, are we put into view mode?
> No, we are put into dired mode.

But we _should_ be put in View mode.  Here's a patch:

*** emacs-21.3/lisp/dired.el.orig       Fri Feb  7 04:48:13 2003
--- emacs-21.3/lisp/dired.el    Fri Apr  9 09:53:54 2004
***************
*** 1396,1402 ****
    (if (file-directory-p (dired-get-filename))
        (or (and (cdr dired-subdir-alist)
               (dired-goto-subdir (dired-get-filename)))
!         (dired (dired-get-filename)))
      (view-file (dired-get-filename))))

  (defun dired-find-file-other-window ()
--- 1396,1403 ----
    (if (file-directory-p (dired-get-filename))
        (or (and (cdr dired-subdir-alist)
               (dired-goto-subdir (dired-get-filename)))
!           (let ((find-file-run-dired t))
!             (view-file (dired-get-filename))))
      (view-file (dired-get-filename))))

  (defun dired-find-file-other-window ()


--
Kevin Rodgers






reply via email to

[Prev in Thread] Current Thread [Next in Thread]