Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t

[martin rudalics]

>>What is the semantics of a "dedicated frame"?
>
>
> I should have said "special-display".
>
> (add-to-list
>  'special-display-buffer-names
>  (list "*Help*" 'my-display-*Help*-frame...))

I did understand you the first time.  The Elisp manual tells me:

     By default, special display means to give the buffer a dedicated
     frame.

No special semantics for "quitting" or "deleting" dedicated frames are
given.  There's a short remark in the Emacs manual

     "Killing the special buffer deletes its frame automatically."

but I'm not sure whether you want to kill the Help buffer and I don't
know what to do when you manually switched to another buffer in that
frame in between.

>>If you "dedicate" a frame to the Help buffer why do you want to switch
>>to a different buffer in that frame?  Why do you want to split that
>>frame's window?
>
>
> I don't; I never said I did. I was describing my overall use, including my
> use of `pop-up-frames', not my use of *Help*. You expressed some assumptions
> about users with non-nil `pop-up-frames' and their never reusing a window
> and never splitting a window. I was explaining that although I have
> `pop-up-frames' non-nil, I still sometimes reuse or split some windows (not
> *Help*, but others).
>

If you do not "reuse" Help windows I don't understand why the proposed
patch doesn't work for you.  You would have to give me a recipe to
reproduce the incorrect behavior.  Problems may arise if and only if a
Help window was reused to display another buffer.

>>I already explained that by default Help buffers are not dedicated thus
>>`quit-window' won't necessarily delete the associated frame.
>
>
> And I explained that I don't personally need you to delete the frame - I do
> that myself. Deleting the window is sufficient (for *Help* or any other
> buffer).

Your personal modifications won't be of any help to other Emacs users.
Let's make this generally usable.

> If there was a buffer in the window before the view-mode buffer is placed in
> it, then it's OK to show that buffer after quitting the view-mode buffer. If
> there was no other buffer in the window before the view-mode buffer, then
> there is no reason to display any buffer at all there - just delete the
> window.

I already explained that tracking the appearance of buffers in a window
is non-trivial and has to be done in `window-configuration-change-hook'.
So far the decision about how to quit view-mode must be established when
_entering_ view-mode.

> And if the view-mode buffer is `one-window-p', then delete the frame
> also.

If people agree that typing `q' should be allowed to unequivocally
delete a frame.