bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#308: vc-delete-file


From: Stefan Monnier
Subject: bug#308: vc-delete-file
Date: Fri, 23 May 2008 17:00:11 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

> first, vc-delete-file is available neither in any menu nor on any key.
> despite your claim to the contrary, this is a common command, used at
> least weakly in an active development environment.

I'm not sure who is "you", but for what it's worth, I agree it should be
available via some key-binding.  Even more so in vc-dir.

> second, when I invoke it with M-x, it requires that the file being
> removed is still present on disk.

That's a bug, indeed.  But I don't see any place in the code where
that's done on purpose.  Could you provide a recipe to reproduce the
problem?  It might depend on the backend.

> this requirement is absurd because when I decide to remove the file from
> the VCS, it is already long gone because I have to remove it to test the
> system without it

No need to argue that it's a bug, I agree.
[ For what it's worth, I'd recommend you vc-delete-file before doing
  your tests, tho.  After all, you can always undo it before committing
  if it turns out it was a bad idea.  ]

> Debugger entered--Lisp error: (error "File myfilename no longer exists!")
>   signal(error ("File myfilename no longer exists!"))
>   error("File %s no longer exists!" "myfilename")
>   revert-buffer(t t t)
>   vc-revert-buffer-internal(t t)
>   vc-resynch-window("myfilename" #<buffer convert_config.mli> t)
>   vc-resynch-buffer("myfilename" #<buffer convert_config.mli> t)
>   vc-delete-file("myfilename")
>   call-interactively(vc-delete-file t nil)
>   execute-extended-command(nil)
>   call-interactively(execute-extended-command nil nil)

> i.e., you just deleted it yourself - and now you are complaining that
> the file does not exist!
> I would rather expect kill-buffer instead of revert-buffer.

I've just changed the code to kill the buffer, indeed.
Thank you,


        Stefan






reply via email to

[Prev in Thread] Current Thread [Next in Thread]