bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#696: marked as done (regexp problem in ldap.el)


From: Emacs bug Tracking System
Subject: bug#696: marked as done (regexp problem in ldap.el)
Date: Tue, 12 Aug 2008 11:50:09 -0700

Your message dated Tue, 12 Aug 2008 14:42:04 -0400
with message-id <address@hidden>
and subject line Re: regexp problem in ldap.el
has caused the Emacs bug report #678,
regarding regexp problem in ldap.el
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden
immediately.)


-- 
678: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=678
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 04:39:02 +0900 User-agent: cmail/2.62 (via feedmail 11-beta-1 I) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/21.4 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI)
Hi,

According to the rfc4512, \w is not good to match aginst attribuite type
and options.  Wtith the attached patch, options containing hyphens are
sucessfully parsed.

P.S.

I submitted a bug report about regexp in ldap-search-internal last
December, but now I understand that it was a mistake.

-- 
/***   Hewlett-Packard Japan, Ltd.                                ***/
/***   Consulting & Integration                                   ***/
/***   PC-CW-SOL#1 Professional Center                            ***/
/***   Nakagawa, Makoto(中川 誠) 050 3158 4747 (Dial-In)        ***/
/***   PGP: 0B33 EAC3 F2F6 3D10 D9E9  AE7F 8EDA 44F9 1D29 D44A    ***/
--[[application/octet-stream; type=patch]「7bit]]
--- ldap.orig.el        2008-08-09 08:04:07.000000000 +0900
+++ ldap.el     2008-08-09 22:37:05.000000000 +0900
@@ -582,9 +582,9 @@
                                               (end-of-line)
                                               (point))))
          (forward-line 1)
-         (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(&lt;[\t 
]*file://\\)\\(.*\\)$")
+         (while (looking-at 
"^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t
 ]+\\(<[\t ]*file://\\)\\(.*\\)$")
            (setq name (match-string 1)
-                 value (match-string 4))
+                 value (match-string 5))
             ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as 
generated by OpenLDAP
             ;; on DOS/Windows as local files.
             (if (and (memq system-type '(windows-nt ms-dos))




--- End Message ---
--- Begin Message --- Subject: Re: regexp problem in ldap.el Date: Tue, 12 Aug 2008 14:42:04 -0400
> According to the rfc4512, \w is not good to match against attribute
> type and options.  With the attached patch, options containing hyphens
> are successfully parsed.

I've checked in a slightly altered version of your patch into CVS.
Thanks very much.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]