bug#1952: 23.0.60[W32-Mingw]; opening etc/HELLO is slower than before

[Jason Rumney]

Juanma Barranquero wrote:
> The change that causes the slowdown in my system is not the one to
> add_one_font_entity_to_list, but this one to add_font_entity_to_list:
>
> @@ -1449,6 +1449,5 @@
>                     && !EQ (spec_charset, Qunicode_bmp)
>                     && !EQ (spec_charset, Qunicode_sip)
> -                   && match_data->pattern.lfCharSet == DEFAULT_CHARSET
> -                   && logical_font->elfLogFont.lfCharSet != DEFAULT_CHARSET)
> +                   && match_data->pattern.lfCharSet == DEFAULT_CHARSET)
>              return 0;
>   
The earlier code never returned 0, always 1, so I don't think that is 
the actual change.

> Reverting this bit eliminates the problem.
>   

Strange, I'd expect that to speed things up, since the new code aborts a 
search that will never find a match where the old code would go through 
all the fonts, returning false matches that would fail later tests.


Can you debug this to see why the earlier version is faster?