[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#2092: 23.0.60; vc-svn-diff

From: Stefan Monnier
Subject: bug#2092: 23.0.60; vc-svn-diff
Date: Sun, 01 Feb 2009 17:39:37 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

> vc-svn-diff fails when oldvers equals (vc-working-revision f).
> In that case "svn diff" executes with no -r argument and only gives
> a diff if the file is locally modified.

That's the right behavior when newvers is nil, isn't it?

> I don't see how it could ever work (please note that I'm not saying that
> it could never work just that I don't see how it could).

I think it was written assuming (incorrectly) that "newvers == nil".
Is the bug fixed if you add (null newvers) to the conjunction?


PS: I see you've already removed this code, but I remember we added
specifically upon request from some users, so it would be better to fix
it than to remove it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]