bug#3928: 23.1.50; compilation-mode not matching perl and more [regression]

[Kevin Ryde]

Running "emacs -Q etc/compilation.txt" and scrolling down to the perl
section shows none of the sample perl errors matched at all, where I
hoped they would be.

I think the "^" anchor added by compilation-mode-font-lock-keywords
means perl and some other more obscure patterns need a ".*", like they
had back in Emacs 21, to work in the middle of a line.

I noticed this on the perl one.  I thought it was working fine not so
long ago, so I don't know what/when/how it went bad.  (The looseness of
Emacs 22 not anchoring reverted, but the patterns not put back at the
same time too??)


2009-07-25  Kevin Ryde  <user42@zip.com.au>

        * progmodes/compile.el (compilation-error-regexp-alist-alist):
        In aix, ftnchek, mips-1, mips-2, perl, sun, 4bsd entries add ".*" so
        as to match in the middle of a line, now that there's a "^" anchor is
        again enforced by compilation-mode-font-lock-keywords.  These patterns
        were otherwise failing to match anything at all.
        In the 4bsd entry remove the "^" from inside the \\(\\) grouping since
        it's now unnecessary and since inside a group it isn't recognised by
        the omake indentation hack in compilation-mode-font-lock-keywords
        (meaning it wouldn't work with indentation).

compile.el.cope-with-anchoring.diff
Description: Text Data

In GNU Emacs 23.1.50.4 (i586-pc-linux-gnu, GTK+ Version 2.16.4)
 of 2009-07-24 on blah.blah
configured using `configure  'CFLAGS=-O -g' '--prefix=/down/emacs/b/inst' 
'--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t