bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#2103: marked as done (Bug in simple.el)


From: Emacs bug Tracking System
Subject: bug#2103: marked as done (Bug in simple.el)
Date: Tue, 11 Aug 2009 04:45:05 +0000

Your message dated Tue, 11 Aug 2009 00:40:04 -0400
with message-id <address@hidden>
and subject line Re: Bug in simple.el (Emacs version 22.2.1)
has caused the Emacs bug report #1973,
regarding Bug in simple.el
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden
immediately.)


-- 
1973: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1973
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Re: Bug in simple.el Date: Thu, 29 Jan 2009 07:06:22 +0000 User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux)
Hi Stefan,

Returning to the bug list, in case others have opinions on the matter...

Quoth Stefan Monnier <address@hidden>:
>> Apologies for contacting you off-list.  I'm doing so just in case you'd
>> given up on me.  My penultimate email to the Emacs bug list was
>> something of a rant!
>>
>> Since then I think I've found the perfect solution.  A hook needs to be
>> added to simple.el providing ^M handling and we don't need to change
>> anything in shell-command.
>>
>>  http://article.gmane.org/gmane.emacs.help/61630
>
> Hooks are great for users, but for internal use they're usually
> better avoided since we can change the code directly instead.

But in this case, some users may not want ^M handling, so providing a
hook gives users the choice, no?

> E.g. in this case we want to change shell-command.

I agree that given the command is called 'shell-command' it would make
sense for ^M characters to be handled in shell-like way, i.e., no ^Ms,
in which case perhaps we should provide a spearate command for users who
_don't_ want ^M handling; 'unfiltered-shell-command' or something like
that?

Then again, adding a hook and leaving shell-command as it stands is the
simplest option and has the advantage of not breaking anything, i.e.,
no backward compatibility issues.

Seb





--- End Message ---
--- Begin Message --- Subject: Re: Bug in simple.el (Emacs version 22.2.1) Date: Tue, 11 Aug 2009 00:40:04 -0400
Closing Bug#1973, since async-shell-command is now in the trunk.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]