bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4374: marked as done (find-file-at-point doesn't recognize absolute


From: Emacs bug Tracking System
Subject: bug#4374: marked as done (find-file-at-point doesn't recognize absolute file paths with trailing line numbers. (Patch included.))
Date: Wed, 09 Sep 2009 02:45:04 +0000

Your message dated Tue, 08 Sep 2009 22:36:42 -0400
with message-id <xnzl94269x.fsf@fencepost.gnu.org>
and subject line Re: bug#4374: find-file-at-point doesn't recognize absolute 
file paths with trailing line numbers. (Patch included.)
has caused the Emacs bug report #4374,
regarding find-file-at-point doesn't recognize absolute file paths with 
trailing line numbers. (Patch included.)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4374: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4374
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
--- Begin Message --- Subject: find-file-at-point doesn't recognize absolute file paths with trailing line numbers. (Patch included.) Date: Tue, 08 Sep 2009 16:42:29 +0200 User-agent: Thunderbird 2.0.0.23 (Windows/20090812) I frequently run across absolute file paths with a trailing line-number specification, e.g. ~/foo.el:7. Find-file-at-point fails to recognize the file part and falls back to opening the parent dir.
Here's the (trivial) fix:
--- emacs-23/lisp/ffap.el
+++ emacs-23/lisp/ffap-fix.el
@@ -1170,7 +1170,7 @@
          ;; remote, you probably already have a connection.
          ((and (not abs) (ffap-file-exists-string name)))
;; Try stripping off line numbers; good for compilation/grep output.
-         ((and (not abs) (string-match ":[0-9]" name)
+         ((and (string-match ":[0-9]" name)
(ffap-file-exists-string (substring name 0 (match-beginning 0)))))
          ;; Try stripping off prominent (non-root - #) shell prompts
         ;; if the ffap-shell-prompt-regexp is non-nil.



--- End Message ---
--- Begin Message --- Subject: Re: bug#4374: find-file-at-point doesn't recognize absolute file paths with trailing line numbers. (Patch included.) Date: Tue, 08 Sep 2009 22:36:42 -0400 User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
hans bennekop wrote:

> I frequently run across absolute file paths with a trailing line-number 
>   specification, e.g. ~/foo.el:7.
> Find-file-at-point fails to recognize the file part and falls back to 
> opening the parent dir.

(I guess path-separator is not ":" on your platform, since if it is
this seems to work for me.)

> Here's the (trivial) fix:

I installed something similar.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]