bug#5840: 24.0.50; wrong tramp-file-name-regexp

[Stefan Monnier]

>> Actually, now that I think about it, I think it's more general
>> than that.  It's basically the idea that the current execution is
>> non-essential (e.g. part of some background computation, or some
>> not-necessarily-expected part of a command like loading a desktop(.el)).
>> So maybe the variable should be in simple.el and named `non-essential'.

> Could you, please, add this variable to simple.el, with a proper
> docstring? I tend to fail with understable descriptions ...

I've just added it.
*BUT* I also realized that your suggested patch:

   ***************
   *** 1028,1034 ****
       "Display a list of possible completions of the current minibuffer 
contents."
       (interactive)
       (message "Making completion list...")
   !   (let* ((start (field-beginning))
              (string (field-string))
              (completions (completion-all-completions
                            string
   --- 1028,1035 ----
       "Display a list of possible completions of the current minibuffer 
contents."
       (interactive)
       (message "Making completion list...")
   !   (let* ((non-essential t)
   !     (start (field-beginning))
              (string (field-string))
              (completions (completion-all-completions
                            string

is not OK: when I hit ? (or TAB) in the minibuffer, I really do want
Tramp to give me the possible completions, even if that requires my
entering a password.

So, it should be added to ido/icomplete and to the original code:

  (add-hook 'minibuffer-setup-hook
            (lambda ()
              (let ((non-essential t))
                (add-hook 'post-command-hook
                          'minibuffer-completion-help nil t))))

but not to the minibuffer-completion-help itself.


        Stefan