bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#5370: M-x hexl-mode M-x hexl-mode leaves unwanted ruler


From: Juanma Barranquero
Subject: bug#5370: M-x hexl-mode M-x hexl-mode leaves unwanted ruler
Date: Thu, 1 Jul 2010 02:21:03 +0200

On Thu, Jul 1, 2010 at 00:46, Chong Yidong <address@hidden> wrote:

> The solution is to avoid saving the old header-line-format if Ruler mode
> is already on.  I've checked in a fix.

OK, thanks.

A couple questions:

Why do you need "(when enable" in ruler--save-header-line-format,
which causes this warning

  ruler-mode.el:562:9:Warning: reference to free variable `enable'

when ruler--save-header-line-format is only called once, like so

  (when enable
     (ruler--save-header-line-format))

?

Also, the docstring for r--s-h-l-f says

"Install the header line format for Ruler mode.
Unless if Ruler mode is already enabled, save the old header line
format first."

Shouldn't that be s/Unless if/Unless/?

    Juanma





reply via email to

[Prev in Thread] Current Thread [Next in Thread]