[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#6539: ispell-complete-word looks for wrong file (at least on w32)
From: |
Agustin Martin |
Subject: |
bug#6539: ispell-complete-word looks for wrong file (at least on w32) |
Date: |
Tue, 6 Jul 2010 17:12:45 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Jul 05, 2010 at 08:23:49PM +0300, Eli Zaretskii wrote:
> > Date: Mon, 5 Jul 2010 13:52:22 +0200
> > From: Agustin Martin <agustin.martin@hispalinux.es>
> > Cc:
> >
> > However, docstrings and error handling for this complete-word stuff needs
> > to be improved, so it provides useful and accurate information. I am
> > currently trying something like attached patch where
> > `ispell-alternate-dictionary' is set to nil if no default is found and
> > checked before use. I find error message too long, but better that before.
> > As usually, suggestions are welcome.
>
> For the error message, just put 2 spaces between the sentences, as we
> do everywhere in Emacs.
Thanks, that is the kind of things casual contributors like me usually
forget.
> For the rest, the patch looks fine, but why not test /usr/dict/words
> with file-readable-p as well? Then, if it does not exist, the
> defcustom will evaluate to nil, and the error message will be even
> more to the point.
Seems already checked. Last /usr/dict/words was originally the return value
when nothing is found and has been removed.
Regarding the `ispell-alternate-dictionary'/`ispell-complete-word-dict'
duality I am modifying `ispell-complete-word-dict' default value to nil and
using
(or ispell-complete-word-dict
ispell-alternate-dictionary))
for previous standalone calls of any of both variables. That way
`ispell-complete-word-dict' is only used if explicitly set and
`ispell-alternate-dictionary' is used otherwise. If they are ever used
for something different this should not disturb and leave things ready.
For those curious, I am attaching a diff with my current changes. Will check
a bit more and if no further problems are found will commit to trunk
tomorrow to allow for wider checking of changes.
--
Agustin
ispell.el_complete-word-3.diff
Description: Text Data
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Agustin Martin, 2010/07/05
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Agustin Martin, 2010/07/05
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Lennart Borgman, 2010/07/05
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Eli Zaretskii, 2010/07/05
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Lennart Borgman, 2010/07/05
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Eli Zaretskii, 2010/07/05
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Lennart Borgman, 2010/07/05
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Eli Zaretskii, 2010/07/05
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Lennart Borgman, 2010/07/05
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Agustin Martin, 2010/07/06
- bug#6539: ispell-complete-word looks for wrong file (at least on w32),
Agustin Martin <=
- bug#6539: ispell-complete-word looks for wrong file (at least on w32), Eli Zaretskii, 2010/07/06
bug#6539: ispell-complete-word looks for wrong file (at least on w32), Stefan Monnier, 2010/07/23