[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7236: 24.0.50; make-local-hook missing
From: |
Stefan Monnier |
Subject: |
bug#7236: 24.0.50; make-local-hook missing |
Date: |
Tue, 19 Oct 2010 12:32:12 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
>> No: m-l-h is also unnecessary when add-hook is called with a nil LOCAL
>> argument. I know of no case where calling make-local-hook makes
>> a difference in Emacs>=21.
> In Emacs 20 also there is a LOCAL optional arg to add-hook.
Yes, but its semantics is slightly different: it means "put it on the
local part of the hook, but only if that local part exists". I.e. it's
only effective if make-local-hook has been called before.
I changed this in Emacs-21 (it an incompatible change, but didn't cause
any bug report AFAIR) which made make-local-hook a NOP.
> Should all code for Emacs 20-24 remove make-local-hook calls and
> instead add `t' to an existing call to add-hook?
No.
If the LOCAL arg is nil, add-hook will only affect the global part of
the hook, regardless of whether make-local-hook has been called.
Stefan
- bug#7236: 24.0.50; make-local-hook missing, Gian Uberto Lauri, 2010/10/18
- bug#7236: 24.0.50; make-local-hook missing, Stefan Monnier, 2010/10/18
- bug#7236: 24.0.50; make-local-hook missing, saint, 2010/10/18
- bug#7236: 24.0.50; make-local-hook missing, Stefan Monnier, 2010/10/18
- bug#7236: 24.0.50; make-local-hook missing, Alan Mackenzie, 2010/10/18
- bug#7236: 24.0.50; make-local-hook missing, Stefan Monnier, 2010/10/18
- bug#7236: 24.0.50; make-local-hook missing, Drew Adams, 2010/10/18
- bug#7236: 24.0.50; make-local-hook missing,
Stefan Monnier <=
- bug#7236: 24.0.50; make-local-hook missing, Drew Adams, 2010/10/19
- bug#7236: 24.0.50; make-local-hook missing, saint, 2010/10/19
- bug#7236: 24.0.50; make-local-hook missing, Stefan Monnier, 2010/10/19