bug#7256: Convert non-ASCII letters to hexadecimal? vs control chars.

[jidanni]

>>>>> "LMI" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
LMI> jidanni@jidanni.org writes:

>> "Convert non-ASCII letters to hexadecimal? (y or n)  y" will still pass
>> control characters. Yes they are ASCII, but who usually wants to pass them?

LMI> grep -nH -e "Convert non-ASCII" *.el

LMI> Grep finished with no matches found at Tue Oct 19 18:45:12

24.0.50/lisp/mail/emacsbug.el.gz:345:              (y-or-n-p "Convert non-ASCII 
letters to hexadecimal? "))

    ;; Check the buffer contents and reject non-English letters.
    ;; FIXME message-mode probably does this anyway.
    (goto-char (point-min))
    (skip-chars-forward "\0-\177")
    (unless (eobp)
      (if (or report-emacs-bug-no-confirmation
              (y-or-n-p "Convert non-ASCII letters to hexadecimal? "))
          (while (progn (skip-chars-forward "\0-\177")
                        (not (eobp)))
            (let ((ch (following-char)))
              (delete-char 1)
              (insert (format "=%02x" ch))))))

Anyway, the typical scenario is the user is asked to submit a backtrace,
and of course backtraces are full of nasty (useful, even?) binary mess
characters, which triggers multiple question upon trying to send, some
from the above, some from message.el.

Anyway, looks like time to fix the FIXME above.