[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7266: Patch to fix minibuffer-complete when icomplete-mode is on and
bug#7266: Patch to fix minibuffer-complete when icomplete-mode is on and completion-cycle-threshold is nil
Thu, 28 Oct 2010 17:40:43 -0400
On Wed, Oct 27, 2010 at 10:23 PM, Stefan Monnier wrote:
>> 2. Type: ESC ESC : (icomplete-mode 1) RET C-h v mini TAB TAB
>> Notice that minibuffer-complete (which is bound to TAB at this point)
>> is cycling through the completion choices instead of popping up a
>> window to display the completion choices.
> Thanks very much. Indeed, there's a problem here, but...
> Hmm... AFAICT if completion-cycle-threshold is nil, then comps will also
> be nil, so this change should not make any difference.
Oddly, my change _did_ fix the problem for me.
> It goes a bit further than that: even if completion-cycle-threshold is
> non-nil and completion-all-sorted-completions is set, it may still be
> wrong to call minibuffer-force-complete since
> completion-all-sorted-completions may only be set because of icomplete
> rather than because we're cycling (e.g. the completion list may be
> larger than the threshold).
> So I've installed the patch below instead. Please confirm that it fixes
> the problem.
I've verified that your patch does indeed fix the problem.