bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#7307: 24.0.50; Mode line had more than just dashes removed


From: Stephen Berman
Subject: bug#7307: 24.0.50; Mode line had more than just dashes removed
Date: Tue, 02 Nov 2010 00:35:25 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

On Mon, 01 Nov 2010 21:32:12 +0200 Eli Zaretskii <address@hidden> wrote:

>> From: Stephen Berman <address@hidden>
>> Date: Mon, 01 Nov 2010 19:11:49 +0100
>> Cc: address@hidden
>> 
>> +  mode_line_filler = !NILP (Fwindow_system (Qnil)) ? lots_of_spaces 
>> +    : lots_of_dashes;
>
> Actually, you want to use `FRAME_WINDOW_P (f)' here.  It does exactly
> what you mean, but with much smaller overhead (for starters, it
> doesn't call Lisp).

Thanks. (I copied Fwindow_system, with the accompanying "This is wrong"
comment, from keyboard.c; I wonder why `FRAME_WINDOW_P (f)' isn't used
there.)

>> -        || field_width > sizeof (lots_of_dashes))
>> +        || field_width > sizeof (mode_line_filler))
>
> mode_line_filler is a pointer, so the result of sizeof here is not
> what you want.

Oops, thanks; I should be more careful with copy 'n' paste.

Thanks for the helpful comments.  I'll wait for Stefan's reply before
posting a corrected (or reworked) patch.

Steve Berman





reply via email to

[Prev in Thread] Current Thread [Next in Thread]