bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#7307: 24.0.50; Mode line had more than just dashes removed


From: Eli Zaretskii
Subject: bug#7307: 24.0.50; Mode line had more than just dashes removed
Date: Tue, 02 Nov 2010 01:35:20 -0400

> From: Stephen Berman <address@hidden>
> Cc: address@hidden
> Date: Tue, 02 Nov 2010 00:35:25 +0100
> 
> On Mon, 01 Nov 2010 21:32:12 +0200 Eli Zaretskii <address@hidden> wrote:
> 
> >> From: Stephen Berman <address@hidden>
> >> Date: Mon, 01 Nov 2010 19:11:49 +0100
> >> Cc: address@hidden
> >> 
> >> +  mode_line_filler = !NILP (Fwindow_system (Qnil)) ? lots_of_spaces 
> >> +    : lots_of_dashes;
> >
> > Actually, you want to use `FRAME_WINDOW_P (f)' here.  It does exactly
> > what you mean, but with much smaller overhead (for starters, it
> > doesn't call Lisp).
> 
> Thanks. (I copied Fwindow_system, with the accompanying "This is wrong"
> comment, from keyboard.c; I wonder why `FRAME_WINDOW_P (f)' isn't used
> there.)

Indeed.  Chong, this is your change:

  2010-08-31  Chong Yidong  <address@hidden>

         * keyboard.c (command_loop_1): Don't call x-set-selection on tty.


Can you tell why you didn't use FRAME_WINDOW_P?  Am I missing some
subtlety?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]