[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7350: 24.0.50; make vc-deduce-backend smarter
From: |
Bob Rogers |
Subject: |
bug#7350: 24.0.50; make vc-deduce-backend smarter |
Date: |
Thu, 18 Nov 2010 21:27:19 -0500 |
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
Date: Wed, 17 Nov 2010 08:31:26 -0500
> Grepping found only one caller; vc-log-edit passes it as the
> log-edit-diff-function. But this really ought to use the passed
> fileset, and not go through the command again, true?
Actually, what it *should* do is select the same fileset as the one
that C-c C-c will commit.
Yes, exactly.
I'm not sure which fileset is chosen by C-c C-c, but if I were to
choose, I'd follow the PCL-CVS behavior which is to recompute the
fileset rather than use whatever was the fileset when the *VC-Log*
buffer was created . . .
The fileset is not recomputed; if you change the fileset in *vc-dir*,
you must do vc-next-action explicitly to update the log buffer fileset.
That threw me for a loop when I first used it, but now that I've gotten
used to it, I can see the utility of it.
(but aditionally check whether the new fileset is the same as the old
one, and if not prompt the user to make sure that's really what she
intended).
Stefan
Sounds like a clear win, since it removes the confusingness while
continuing to allow both behaviors. Accordingly, that ought to get
fixed first. If I come up with a reasonable patch, I'll file a new bug
report.
-- Bob
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Bob Rogers, 2010/11/06
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Stefan Monnier, 2010/11/07
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Bob Rogers, 2010/11/07
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Stefan Monnier, 2010/11/08
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Bob Rogers, 2010/11/08
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Stefan Monnier, 2010/11/12
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Bob Rogers, 2010/11/14
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Stefan Monnier, 2010/11/15
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Bob Rogers, 2010/11/16
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Stefan Monnier, 2010/11/18
- bug#7350: 24.0.50; make vc-deduce-backend smarter,
Bob Rogers <=
- bug#7350: 24.0.50; make vc-deduce-backend smarter, Bob Rogers, 2010/11/20