bug#7941: 24.0.50; Compilation mode broken, next-error not working

[Stefan Monnier]

> (setq compilation-scroll-output t)
> M-x compile (somewhere where you get warnings or errors).
> M-x next-error
> compilation-next-error-function: Wrong type argument: arrayp, nil

Thanks, I just installed the patch below which should fix it.

> M-x compile
> run-hooks: Wrong type argument: number-or-marker-p, nil

I believe I've fixed this one yesterday or so.

> Can the "compilation--flush-parse: 1 16056" messages be turned off?

No, of course not, they're crucial for the user.


        Stefan "just kidding"


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog      2011-02-01 10:12:25 +0000
+++ lisp/ChangeLog      2011-02-01 16:31:01 +0000
@@ -1,3 +1,8 @@
+2011-02-01  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+       * progmodes/compile.el (compilation-next-error): Check there's
+       a message before using it (bug#7941).
+
 2011-02-01  Jay Belanger  <jay.p.belanger@gmail.com>
 
        * calc/calc-mtx.el (math-lud-pivot-check): New function.
@@ -6,8 +11,8 @@
 
 2011-01-31  Alan Mackenzie  <acm@muc.de>
 
-       * progmodes/cc-cmds.el (c-forward-over-illiterals): Continue
-       parsing if we encounter a naked # (Bug#7595).
+       * progmodes/cc-cmds.el (c-forward-over-illiterals):
+       Continue parsing if we encounter a naked # (Bug#7595).
        (c-beginning-of-statement): Avoid loop in locating the beginning
        of a macro.
 
@@ -34,8 +39,8 @@
 
 2011-01-31  Kenichi Handa  <handa@m17n.org>
 
-       * international/quail.el (quail-keyboard-layout-alist): Remove
-       superfluous SPC for "pc105-uk" (bug#7927).
+       * international/quail.el (quail-keyboard-layout-alist):
+       Remove superfluous SPC for "pc105-uk" (bug#7927).
 
 2011-01-31  Glenn Morris  <rgm@gnu.org>
 

=== modified file 'lisp/progmodes/compile.el'
--- lisp/progmodes/compile.el   2011-01-31 17:11:11 +0000
+++ lisp/progmodes/compile.el   2011-02-01 16:28:10 +0000
@@ -2140,7 +2140,7 @@
   (or pt (setq pt (point)))
   (let* ((msg (get-text-property pt 'compilation-message))
          ;; `loc', `msg', and `last' are used by the compilation-loop macro.
-        (loc (compilation--message->loc msg))
+        (loc (and msg (compilation--message->loc msg)))
         last)
     (if (zerop n)
        (unless (or msg                 ; find message near here
@@ -2154,8 +2154,7 @@
                                                  (line-end-position)))
            (or (setq msg (get-text-property pt 'compilation-message))
                (setq pt (point)))))
-      (setq last (compilation--loc->file-struct
-                  (compilation--message->loc msg)))
+      (setq last (compilation--loc->file-struct loc))
       (if (>= n 0)
          (compilation-loop > compilation-next-single-property-change 1-
                            (if (get-buffer-process (current-buffer))