[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9118: 23.3.50; Don't seed the RNG in message-unique-id
From: |
Leo |
Subject: |
bug#9118: 23.3.50; Don't seed the RNG in message-unique-id |
Date: |
Tue, 19 Jul 2011 00:42:10 +0800 |
Function message-unique-id seeds the RNG every time it runs and relies
on its undocumented return value. Should something like this be applied?
--- a/message.el
+++ b/message.el
@@ -5484,7 +5484,8 @@
;; Don't use microseconds from (current-time), they may be unsupported.
;; Instead we use this randomly inited counter.
(setq message-unique-id-char
- (% (1+ (or message-unique-id-char (logand (random t) (1- (lsh 1 20)))))
+ (% (1+ (or message-unique-id-char
+ (logand (random most-positive-fixnum) (1- (lsh 1 20)))))
;; (current-time) returns 16-bit ints,
;; and 2^16*25 just fits into 4 digits i base 36.
(* 25 25)))
Diff finished. Tue Jul 19 00:34:45 2011
Leo
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id,
Leo <=
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Lars Magne Ingebrigtsen, 2011/07/19
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Leo, 2011/07/19
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Lars Magne Ingebrigtsen, 2011/07/19
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Leo, 2011/07/19
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Lars Magne Ingebrigtsen, 2011/07/19
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Leo, 2011/07/19
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Lars Magne Ingebrigtsen, 2011/07/20
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Leo, 2011/07/21
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Juanma Barranquero, 2011/07/21
- bug#9118: 23.3.50; Don't seed the RNG in message-unique-id, Leo, 2011/07/21