[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9409: 24.0.50; log-view-msg-prev, easy-mmode
From: |
Stefan Monnier |
Subject: |
bug#9409: 24.0.50; log-view-msg-prev, easy-mmode |
Date: |
Tue, 13 Sep 2011 17:02:09 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
> I patched `easy-mmode-define-navigation' as above and tested (marked
> as X) the most functions without any trouble.
> * diff-mode.el
> - [X] diff-hunk-prev
> - [X] diff-hunk-next
> - [X] diff-file-prev
> - [X] diff-file-next
> * log-view.el
> - [X] log-view-msg-prev
> - [X] log-view-msg-next
> - [ ] log-view-file-prev
> - [ ] log-view-file-next
> * smerge-mode
> - [ ] smerge-next
> - [ ] smerge-prev
> * cvs-status
> - [X] cvs-status-next
> - [X] cvs-status-prev
If a problem shows up it's not going to be in the *-prev commands, but
in commands that call those functions internally. So you need to check
the callers of diff-hunk-prev, diff-file-prev, etc..
It's always good to check with actual testing, but it's also important
to check by looking at the code. IIUC this will be safe because in the
case where the behavior is changed, the function signals an error, so
only callers which catch this error (with condition-case) might
be affected.
Stefan