[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9990: valgrind warning in add_row_entry
From: |
Dan Nicolaescu |
Subject: |
bug#9990: valgrind warning in add_row_entry |
Date: |
Fri, 18 Nov 2011 16:43:11 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Dan Nicolaescu <dann@gnu.org>
>> Cc: 9990@debbugs.gnu.org
>> Date: Fri, 18 Nov 2011 14:40:34 -0500
>>
>> > I added such an assert to the trunk. I also fixed a couple of
>> > functions that were destroying the validity of hash codes while
>> > manipulating glyph rows.
>> >
>> > Could you please see if valgrind still complains about add_row_entry
>> > with the current trunk?
>>
>> Unfortunately it still complains in:
>>
>> ==11270== at 0x41314F: adjust_glyph_matrix (dispnew.c:612)
>
> What does this line say in your sources?
>
xassert (!row->enabled_p || verify_row_hash (row));
> Anyway, seems like a different thing, as there's no add_row_entry near
> line 612.
And for the other complaint:
==11270== by 0x415762: update_window (dispnew.c:4244)
is:
ptrdiff_t i = row->hash % row_table_size;
- bug#9990: valgrind warning in add_row_entry, (continued)
- bug#9990: valgrind warning in add_row_entry, Dan Nicolaescu, 2011/11/11
- bug#9990: valgrind warning in add_row_entry, Eli Zaretskii, 2011/11/11
- bug#9990: valgrind warning in add_row_entry, Eli Zaretskii, 2011/11/11
- bug#9990: valgrind warning in add_row_entry, Dan Nicolaescu, 2011/11/11
- bug#9990: valgrind warning in add_row_entry, Eli Zaretskii, 2011/11/12
- bug#9990: valgrind warning in add_row_entry, Dan Nicolaescu, 2011/11/15
- bug#9990: valgrind warning in add_row_entry, Eli Zaretskii, 2011/11/15
- bug#9990: valgrind warning in add_row_entry, Eli Zaretskii, 2011/11/18
- bug#9990: valgrind warning in add_row_entry, Dan Nicolaescu, 2011/11/18
- bug#9990: valgrind warning in add_row_entry, Eli Zaretskii, 2011/11/18
- bug#9990: valgrind warning in add_row_entry,
Dan Nicolaescu <=
- bug#9990: valgrind warning in add_row_entry, Eli Zaretskii, 2011/11/19
- bug#9990: valgrind warning in add_row_entry, Dan Nicolaescu, 2011/11/20
- bug#9990: valgrind warning in add_row_entry, Dan Nicolaescu, 2011/11/15
- bug#9990: valgrind warning in add_row_entry, Eli Zaretskii, 2011/11/15
- bug#9990: valgrind warning in add_row_entry, Dan Nicolaescu, 2011/11/11