[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#10150: deactive->inactive, inactivate->deactivate spelling fixes

From: Štěpán Němec
Subject: bug#10150: deactive->inactive, inactivate->deactivate spelling fixes
Date: Tue, 03 Jan 2012 17:55:55 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

On Sat, 31 Dec 2011 07:12:26 +0100
Paul Eggert wrote:

> On 11/29/11 03:47, Štěpán Němec wrote:
>> IMO all commands, hooks and user variables definitely need deprecation,
>> the rest should at least be mentioned in NEWS.
> OK, thanks, attached is an improved version of the patch that
> should do all that.  I'll also look at improving the
> other patches I recently submitted re fixing spelling
> problems in the code.

Thank you!

Several problems I noticed:

1) `hangul-input-method-inactivate', `quail-inactivate',
`robin-inactivate' and `ucs-input-inactivate' are all interactive
functions (= commands), but you still just rename them without any
deprecation (cf. `define-obsolete-function-alias').

2) You only use `make-obsolete-variable' to mark user variables obsolete
(and retain both the original and the new defcustoms), which will
produce compiler warnings for the old variable, but doesn't provide any
clear connection between the two. It would be better to use
`define-obsolete-variable-alias' (which presumably also prevents other
problems, see its docstring) and only use `defcustom' for the new

3) The new or changed `defcustoms' should get a :version tag.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]