bug#10513: 23.3; vc-modify-change-comment broken in emacs-23.3-8.fc16

[Glenn Morris]

Version: 24.0.93

Francis.Montagnac@inria.fr wrote:

> Modifying (even under emacs -q) a change log entry typing 'e' from
> *VC-log* break when typing C-c C-c with the message:
>
>   apply: Symbol's value as variable is void: backend
>
> I found a turnaround: use a lexical-let instead of a let in
> vc-modify-change-comment:
>
> <   (let ((backend (vc-responsible-backend (car files))))
>>   (lexical-let ((backend (vc-responsible-backend (car files))))

Thanks for the report. I installed something similar:


*** lisp/vc/vc.el       2012-01-19 07:21:25 +0000
--- lisp/vc/vc.el       2012-01-25 00:05:40 +0000
***************
*** 1880,1886 ****
       "Enter a replacement change comment."
       "*vc-log*"
       (lambda () (vc-call-backend backend 'log-edit-mode))
!      (lexical-let ((rev rev))
         (lambda (files comment)
           (vc-call-backend backend
                            'modify-change-comment files rev comment))))))
--- 1880,1887 ----
       "Enter a replacement change comment."
       "*vc-log*"
       (lambda () (vc-call-backend backend 'log-edit-mode))
!      (lexical-let ((rev rev)
!                    (backend backend))
         (lambda (files comment)
           (vc-call-backend backend
                            'modify-change-comment files rev comment))))))