[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#10592: Bug#655118: Please enabled hardened build flags
From: |
Eli Zaretskii |
Subject: |
bug#10592: Bug#655118: Please enabled hardened build flags |
Date: |
Wed, 25 Jan 2012 01:40:26 -0500 |
> From: Rob Browning <rlb@defaultvalue.org>
> Cc: 10592@debbugs.gnu.org, 655118@bugs.debian.org,
> 655118-forwarded@bugs.debian.org, jmm@inutil.org
> Date: Tue, 24 Jan 2012 20:22:52 -0600
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I think the right fix for this is to declare `error' with the
> > appropriate printf attribute. Alternatively, you could use variable
> > argument lists and call vprintf instead.
>
> Would something like this be acceptable, and if not, how would you like
> to see it adjusted? The patch changes error() to use an ANSI
> declaration, and it relies on the printf format attribute:
This is fine with me, but please use ATTRIBUTE_FORMAT_PRINTF (defined
in src/config.h) instead of a literal __attribute__(...), which is a
GCC-only thing.
Thanks.
bug#10592: Bug#655118: Please enabled hardened build flags, Paul Eggert, 2012/01/30