[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11068: 24.0.94; Face-remapped background does not extend to end of w
From: |
Chong Yidong |
Subject: |
bug#11068: 24.0.94; Face-remapped background does not extend to end of window |
Date: |
Sun, 25 Mar 2012 14:20:57 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> Here I disagree: I think we should confine the internal details of
> face remapping to lookup_basic_face, instead of spilling our knowledge
> about that all over. As you just said above, if face-remapping-alist
> is nil, that function returns immediately, so there's nothing lost
> here for the "usual" use-case.
I don't know how making use of the return value from a previous call to
lookup_basic_face (when default_face was assigned) is "spilling our
knowledge", but whatever; it's not a important point.
> OK, but to be absolutely fair, I must point out that, while the patch
> is very simple, it has one non-trivial consequence: when the default
> face _is_ remapped, the empty space to the right of any L2R line and
> the empty lines beyond EOB are filled with stretch glyphs of a
> suitably computed width. Before the patch, there were no glyphs in
> those places. So, from the POV of the content of the glyph matrices,
> the change introduced by these patches is quite prominent. In
> particular, this could potentially affect any code that examines the
> glyphs of a glyph matrix; previously, such stretch glyphs were only
> present at the left side of R2L glyph rows.
Hmm, you're right, that is a non-trivial change. The implications of
that are not obvious to me. Maybe we should delay this for post-24.1
then.
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, (continued)
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, martin rudalics, 2012/03/30
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Stefan Monnier, 2012/03/24
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, martin rudalics, 2012/03/24
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Chong Yidong, 2012/03/24
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Eli Zaretskii, 2012/03/24
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Chong Yidong, 2012/03/24
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Eli Zaretskii, 2012/03/25
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window,
Chong Yidong <=
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, martin rudalics, 2012/03/25
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Eli Zaretskii, 2012/03/25
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, martin rudalics, 2012/03/25
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Eli Zaretskii, 2012/03/25
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Chong Yidong, 2012/03/26
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Eli Zaretskii, 2012/03/26
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Eli Zaretskii, 2012/03/30
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, martin rudalics, 2012/03/25
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, Eli Zaretskii, 2012/03/25
- bug#11068: 24.0.94; Face-remapped background does not extend to end of window, martin rudalics, 2012/03/25