[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11130: [PATCH] Reopen bug#10489: 24.0.92; dired-do-copy may create i
From: |
Thierry Volpiatto |
Subject: |
bug#11130: [PATCH] Reopen bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy |
Date: |
Fri, 30 Mar 2012 07:18:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) |
Hi,
I reopen this as it seem it is not fixed.
(Moved from emacs-dev list)
I attach the patch again here, please review and try it.
patch-r119231.patch
Description: bugfix
--8<---------------cut here---------------start------------->8---
Hi,
I had sent a reply to
bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy
after it had been closed, saying that there are still problems.
Unfortunately I got no answer. Since it was an important bug: Can
please somebody have a look? Thanks.
This was my message:
Hello again,
I'm afraid there are still problems. I encountered these two:
1. Creating symlinks to parent directories doesn't work anymore.
E.g. if you have a directory "~/test/dir1/", open a dired for "~", go to
"test/", hit S, enter "~/test/dir1/" and hit RET. You get the error
dired-create-files: Cannot copy `/home/micha/test' into its
subdirectory `/home/micha/test/dir1/test'
But I only wanted a symlink... This worked in Emacs 23.
2. Symlinks to parent directories (still) lead to ininite loops when
copying containing dir.
To use the above example: just create this symlink from outside Emacs,
so you get e.g. this:
/home/micha/test/dir1:
total used in directory 8,0K available 94267456
drwxr-xr-x 2 micha users 4,0K Mär 22 02:32 .
drwxr-xr-x 3 micha users 4,0K Mär 22 02:33 ..
lrwxrwxrwx 1 micha users 22 Mär 22 02:32 test -> /home/micha/test
Now dired "~", and copy "~/test" to "~/test2". You get a hierarchy
~/test2/dir1/test/dir1/test/...
again (the command terminates without error, btw). And all these
are real directories, and _not_ symlinks!
I also wonder why dired doesn't copy the symlink itself, but copies the
target instead? This seems to be the case also in other examples. If I
copy a directory containing any symlinks with dired, copying always
copies the targets of the symlinks.
Michael
--8<---------------cut here---------------end--------------->8---
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
- bug#11130: [PATCH] Reopen bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy,
Thierry Volpiatto <=