bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#11711: 24.0.95; [PATCH] added imenu and which-func support to rst.el


From: Stefan Monnier
Subject: bug#11711: 24.0.95; [PATCH] added imenu and which-func support to rst.el
Date: Thu, 14 Jun 2012 21:46:00 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

> This is not a bug report. This is a request to merge a patch
> to the offcial source tree.

> 2012-06-13  Masatake YAMATO  <address@hidden>

>       * textmodes/rst.el (rst-mode, rst-imenu-index): Added
>       imenu and which-func support.

I'll let the other Stefan decide what to do with it.  It looks
pretty good for me.  Just a few nitpicks below:

> +  ;; Imenu
> +  (set (make-local-variable 'imenu-create-index-function) 'rst-imenu-index)
> +
> +  ;;  Which func
> +  (when (and (boundp 'which-func-modes) (listp which-func-modes))
> +    (add-to-list 'which-func-modes 'rst-mode))
> +
>    ;; Font lock.

Try to punctuate your comments.

> +(defun rst-imenu-find-adornments-for-position (adornments p)
> +  "Find adornments cell for position P in ADORNMENTS"

And do punctuate your docstring (C-u M-x checkdoc-current-buffer RET
might help you catch such things).


        Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]