[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12345: 24.2.50; doc string of `text-scale-adjust'
From: |
Bastien |
Subject: |
bug#12345: 24.2.50; doc string of `text-scale-adjust' |
Date: |
Tue, 11 Sep 2012 16:53:06 +0200 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) |
Hi Drew,
"Drew Adams" <drew.adams@oracle.com> writes:
> 1. I think any changes in the behavior and bindings should be proposed on
> emacs-devel. Personally, I don't care much, but I'm pretty sure that at least
> some people will want to keep the `=' binding because `+' is often on a Shift
> key. Emacs-devel is also the place to pose your question about zero.
Right, I will ask on emacs-devel.
> 2. Please consider changing the name of the parameter to INCREMENT, so the doc
> string is more readable: "Adjust the height of the default face by INCREMENT."
> Say explicitly that INCREMENT defaults to 1.
"INC" seems a rather standard and self-explanatory pet name for
"INCREMENT".
> 3. Alternatively, you could say something like this:
>
> "Adjust the height of face `default' by N text-scale steps.
> N is the numeric prefix agument: positive to increase height, negative
> to decrease. Step size is the value of `text-scale-mode-step'."
Yes.
> 4. Don't be surprised if Stefan doesn't go along with your change to not use
> the
> temporary keymap. He just got through _adding_ such code here and there
> throughout Emacs. (Makes no difference to me - my bug report was about the
> doc
> string.)
I've nothing against temporary keymaps -- I thought the buggy behavior
I've found and reported was the default one, so I just implemented
text-scale-adjust another way. Also, I think the (while ... read-event)
construct is a simple way to keep the message displayed. But surely
more a matter of taste than a technical point.
<Thanks for the feedback,
--
Bastien
- bug#12345: 24.2.50; doc string of `text-scale-adjust', (continued)
- bug#12345: 24.2.50; doc string of `text-scale-adjust', Stefan Monnier, 2012/09/12
- bug#12345: 24.2.50; doc string of `text-scale-adjust', Bastien, 2012/09/12
- bug#12345: 24.2.50; doc string of `text-scale-adjust', Drew Adams, 2012/09/12
- bug#12345: 24.2.50; doc string of `text-scale-adjust', Stefan Monnier, 2012/09/12
- bug#12345: 24.2.50; doc string of `text-scale-adjust', Bastien, 2012/09/11
bug#12345: 24.2.50; doc string of `text-scale-adjust', Drew Adams, 2012/09/11
- bug#12345: 24.2.50; doc string of `text-scale-adjust',
Bastien <=