[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13845: 24.3.50; gud commands stop responding when using gdb-mi
From: |
Glenn Morris |
Subject: |
bug#13845: 24.3.50; gud commands stop responding when using gdb-mi |
Date: |
Wed, 01 May 2013 22:20:35 -0400 |
User-agent: |
Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) |
Thanks. I'm not familiar with gdb, so these are style comments only.
Jean-Philippe Gravel wrote:
> + * progmodes/gdb-mi.el (gdb-running, gdb-starting): Removed
> + signals for which replies were never received.
Use the present tense for ChangeLog entries.
> + (gdb-wait-for-pending): Fix invalid backquote. Use gdb-handler-list.
> + instead of gdb-pending-triggers. Update docstring.
Two spaces between sentences.
> ! (defcustom gdb-discard-unordered-replies t
> ! "When non-nil, any out-of-order GDB replies are discarded.
Use the active voice; eg
Non-nil means discard any out-of-order GDB replies.
> ! This mechanism is provided as a protection against lost GDB replies,
> ! assuming that GDB always replies in the same order Emacs is sending
> ! commands. When receiving a reply with a given token-number, any
> ! pending messages with a lower token-number are considered out-of-order.
This protects against lost GDB replies, assuming that GDB always
replies in the same order as Emacs sends commands. When receiving a
reply with a given token-number, assume any pending messages with a
lower token-number are out-of-order.
> ! (cl-defstruct gdb-handler
> ! "Structure used to keep track of the commands sent to GDB and
> ! handle the replies received."
First line of doc should be a complete sentence.
> ! Handlers are used to keep track the commands sent to GDB and to handle the
Remove "keep", or add "of" (keep track of).
> ! replies received. TOKEN-NUMBER is the number used as prefix of the GDB/mi
> ! command sent.
Active voice: Use TOKEN-NUMBER as the prefix...
> ! Upon reception of a reply prefixed with the same TOKEN-NUMBER,
> ! the callback HANDLER-FUNCTION is invoked.
active: invoke the callback...
> ! Additionally, if `gdb-discard-unordered-replies' is non-nil, all handlers
> ! having a token number less than TOKEN-NUMBER are discarded."
active: discard all handlers...
> ! This involves invoking the callback registered with this token number
> ! in `gdb-handler-list' and clearing all pending handlers invalidated
> ! by the reception of this reply."
This invokes the handler ... and clears all pending...
- bug#13845: 24.3.50; gud commands stop responding when using gdb-mi,
Glenn Morris <=