[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14345: 24.3; shr-insert-document crashes gtk-emacs
From: |
Paul Eggert |
Subject: |
bug#14345: 24.3; shr-insert-document crashes gtk-emacs |
Date: |
Sun, 12 May 2013 12:21:21 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 |
I installed the following patch as trunk bzr 112562 to fix
this. It works for me, including for Glenn's C-c C-c test.
I'll cross my fingers and mark the bug as fixed.
=== modified file 'src/ChangeLog'
--- src/ChangeLog 2013-05-09 18:30:46 +0000
+++ src/ChangeLog 2013-05-12 19:14:22 +0000
@@ -1,3 +1,7 @@
+2013-05-12 Paul Eggert <eggert@cs.ucla.edu>
+
+ * image.c (gif_load): Check that subimages fit (Bug#14345).
+
2013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
* lread.c (skip_dyn_eof): New function.
=== modified file 'src/image.c'
--- src/image.c 2013-04-07 04:41:19 +0000
+++ src/image.c 2013-05-12 19:15:38 +0000
@@ -7263,6 +7263,25 @@
return 0;
}
+ /* Check that the selected subimages fit. It's not clear whether
+ the GIF spec requires this, but Emacs can crash if they don't fit. */
+ for (j = 0; j <= idx; ++j)
+ {
+ struct SavedImage *subimage = gif->SavedImages + j;
+ int subimg_width = subimage->ImageDesc.Width;
+ int subimg_height = subimage->ImageDesc.Height;
+ int subimg_top = subimage->ImageDesc.Top;
+ int subimg_left = subimage->ImageDesc.Left;
+ if (! (0 <= subimg_width && 0 <= subimg_height
+ && 0 <= subimg_top && subimg_top <= height - subimg_height
+ && 0 <= subimg_left && subimg_left <= width - subimg_width))
+ {
+ image_error ("Subimage does not fit in image", Qnil, Qnil);
+ fn_DGifCloseFile (gif);
+ return 0;
+ }
+ }
+
/* Create the X image and pixmap. */
if (!x_create_x_image_and_pixmap (f, width, height, 0, &ximg, &img->pixmap))
{
bug#14345: 24.3; shr-insert-document crashes gtk-emacs,
Paul Eggert <=