bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14925: 24.3.50; `image-dired.el' code (minor)


From: Drew Adams
Subject: bug#14925: 24.3.50; `image-dired.el' code (minor)
Date: Thu, 25 Jul 2013 22:31:06 -0700 (PDT)

> > > 1. `image-dired-dired-file-marked-p' uses regexp "^ .*$", which I think
> > > is the same as "^ " (which is simpler).
> >
> > It's similar, except for (match-end 0) and the position of point after
> > re-search-forward.  I haven't looked at the code to see if the
> > difference matters.
> 
> It does not; the match data and the position of point are not used.
> (The `-p' suffix provides a clue.)  There is currently only one occurrence
> of `image-dired-dired-file-marked-p':
> 
> (if (image-dired-dired-file-marked-p)
>     (dired-unmark 1)
>   (dired-mark 1))

It also uses `save-excursion' and `looking-at', not `re-search-forward'.

However, as it is in principle just a predicate it should probably also
use `looking-at-p', not `looking-at'.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]