bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#9803: [PATCH] Add ERT option to skip test


From: Stefan Monnier
Subject: bug#9803: [PATCH] Add ERT option to skip test
Date: Mon, 21 Oct 2013 12:53:14 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

> Well, I've made a change to call (fset 'skip-if 'ert--skip-if) in
> ert--run-test-internal. After running the test, it is reverted by
> (unintern 'skip-if nil).

Yuck!

> Therefore, `skip-if' is visible only inside tests defined with
> `ert-deftest'.

Not "inside" but "during".  I.e. it can still affect any code run during
the tests.

> If this is acceptable, I could apply this change also for
> `should', `should-not' and `should-error'.

No, better leave them as always-global.

> I've tried to change it as proposed by Stefan, but I'm too stupid to
> manage all this sophisticated cl-* stuff :-(

What have you tried and how did it fail?


        Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]