bug#15648: 24.2.50; gnutls SSL connection to IMAP server causes emacs to crash completely

[Ted Zlatanov]

On Mon, 04 Nov 2013 19:06:48 +0200 Eli Zaretskii <eliz@gnu.org> wrote: 

>> From: Ted Zlatanov <tzz@lifelogs.com>
>> Cc: emacs@kosowsky.org,  15648@debbugs.gnu.org
>> Date: Mon, 04 Nov 2013 11:44:41 -0500
>> 
EZ> If so, perhaps the problem is that we leave the process object
EZ> marked as a GnuTLS process, but with a NULL state?  Should we remove
EZ> the mark, or maybe delete the process object in gnutls-negotiate?
>> >> 
>> >> I would abort with a message like any other error.
>> 
EZ> Maybe you should install a change that does that, and see if it solves
EZ> the problem.
>> 
>> You mean like this?

EZ> Something like that, yes.

>> Should I have a special check for "gnutls_p is set but gnutls_state
>> is NULL"?

EZ> That's what this patch does, doesn't it?  Or did I misunderstand you?

The process.c change checks that "gnutls_p is set and gnutls_state
is not NULL" but wouldn't make a note of the case where gnutls_state got
set to NULL somehow.  I meant to have a special check for that case and
maybe issue a message... but it seems a bit like overkill.

>> You're absolutely right.  Can you check if this patch is good?  It looks
>> OK to me.

EZ> It compiles fine.  But since I cannot reproduce the original problem,
EZ> I'd ask the OP to please see if this fixes that problem.

Right, I needed your review to ensure I was not missing something :)

OP, can you please try my patch?

Ted