[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15754: 24.3.50; [PATCH] vc-ignore makes no sense
From: |
Dmitry Gutov |
Subject: |
bug#15754: 24.3.50; [PATCH] vc-ignore makes no sense |
Date: |
Sat, 07 Dec 2013 05:07:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Hi Andreas,
Andreas Politz <politza@hochschule-trier.de> writes:
> There are two problems with this function.
Or maybe three. :)
The changes in the code and the functions signature look good to me, but
I think the docstring actually became less accurate in places.
> ! (defun vc-ignore (file &optional directory remove-p)
> ! "Ignore or remove FILE under the VCS of DIRECTORY.
"Remove file under the VCS" means something completely different.
> ! Interactively, FILE is ignored, unless a prefix argument is
> ! given, which queries for a FILE to remove from the list of
> ! ignored files."
Maybe "...in which case the function queries..."?
And I think the usual form would be, "When called interactively, ignore
FILE, unless ..., in which case prompt ...". You can grep Emacs source
code for "When called interactively".
- bug#15754: 24.3.50; [PATCH] vc-ignore makes no sense,
Dmitry Gutov <=