[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next sel
From: |
Kenjiro NAKAYAMA |
Subject: |
bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field. |
Date: |
Sun, 22 Dec 2013 10:56:53 +0900 |
User-agent: |
mu4e 0.9.9.6pre2; emacs 24.3.50.1 |
> It doesn't apply cleanly anymore, sorry. Can you rebase and resend?
Sorry, it's my mistake. This is proper patch.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-tag-select): Add text-property to jump to
next select field.
---
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 15bb2c0..cd59380 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -847,6 +847,8 @@ See URL
`https://developer.mozilla.org/en-US/docs/Web/HTML/Element/
(put-text-property start (point) 'eww-form menu)
(add-face-text-property start (point) 'eww-form-select)
(put-text-property start (point) 'keymap eww-select-map)
+ (unless (= start (point))
+ (put-text-property start (1+ start) 'help-echo "select field"))
(shr-ensure-paragraph))))
(defun eww-select-display (select)
--
Kenjiro NAKAYAMA
tzz@lifelogs.com writes:
> On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA
> <nakayamakenjiro@gmail.com> wrote:
>
>>> Such comments should describe what the change *does* rather than what it
>>> *did*, i.e. use the present tense (and capitalize the word after the
>>> colon since it starts a sentence).
>
> KN> Thank you Stefan.
>
> KN> I resend patch with a fixed comment.
>
> KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
>
> KN> * net/eww.el (eww-tag-select): Add text-property to jump to
> KN> next select field.
>
> It doesn't apply cleanly anymore, sorry. Can you rebase and resend?
>
> Thanks
> Ted