bug#16300: 24.3.50; 'M-<F10>' doesn't work always

[martin rudalics]

> It seems fixed, indeed.

The current code still doesn't catch all possible transitions.  For
example, a FULLSCREEN_HEIGHT followed by two M-<F10>s will get you a
normalized window which is arguable not TRT but catching this without
introducing additional states seems hardly possible.  Here I do

(defun toggle-full-height ()
  (interactive)
  (if (eq (frame-parameter nil 'fullscreen) 'fullheight)
      (set-frame-parameter nil 'fullscreen 'fullnone)
    (set-frame-parameter nil 'fullscreen 'fullheight)))

which IMO is the best way to use the FULLHEIGHT feature.

I'll close this bug.

> And BTW, I don't know if it's due to this change, but I can't
> reproduce the bug #14239 anymore with the current trunk.

The old code used SetWindowPos which according to

http://msdn.microsoft.com/en-us/library/windows/desktop/ms632611%28v=vs.85%29.aspx

should not be used:

  The coordinates used in a WINDOWPLACEMENT structure should be used
  only by the GetWindowPlacement and SetWindowPlacement
  functions. Passing workspace coordinates to functions which expect
  screen coordinates (such as SetWindowPos) will result in the window
  appearing in the wrong location. For example, if the taskbar is at the
  top of the screen, saving window coordinates using GetWindowPlacement
  and restoring them using SetWindowPos causes the window to appear to
  "creep" up the screen.

> So it could
> be closed as well.

Please do that.

martin