bug#16804: 24.3.50; [PATCH] fix with-silent-modifications

[Stefan Monnier]

> (defun bug ()
>   (setq-local eldoc-documentation-function #'bug-1)
>   (setq js2-idle-timer-delay 0.2)
>   (when buffer-file-name
>     (eldoc-mode 1)))
> (defun bug-1 ()
>   (message "::%S::" buffer-file-name))

Sounds like there's a bug in js2-mode which causes it to run
eldoc-documentation-function from within a with-silent-modifications
(maybe because of a sit-for within a with-silent-modifications?).
This would be a bug regardless of whether we change
with-silent-modifications.

Again, a backtrace would be much more useful.


        Stefan