bug#17486: 24.4.50; set-face-font problem on OSX

[Jan D.]

Hello.

This commit introduced the error, I suspect the error is present on all 
ports:

revno: 116927
committer: Dmitry Antipov
branch nick: trunk
timestamp: Wed 2014-04-02 17:24:19 +0400
message:
  * font.c (font_list_entities): Do not add empty vector to font cache.
  (font_matching_entity): Likewise.  If matching entity is found, insert
  1-item vector with this entity instead of entity itself (Bug#17125).


        Jan D.

Jan Djärv skrev 2014-05-16 07:06:
> Hello.
>
> 13 maj 2014 kl. 20:21 skrev Christian Lynbech <christian@defun.dk>:
>
> > There is an issue when trying to set the font of face in recent versions
> > of emacs build for OSX.
> >
> > Evaluating this form works as expected:
> >
> >     (set-face-font 'region 
> > "-*-Menlo-normal-normal-normal-*-12-*-*-*-m-0-iso10646-1")
> >
> > It used to be that one could also say something like this:
> >
> >     (set-face-font 'region  "bitstream vera sans mono-26")
> >
> > but when I try to do that on a newly built emacs, I get this stack
> > trace:
> >
> >     Debugger entered--Lisp error: (wrong-type-argument font [#<font-entity ns 
> > apple Menlo nil iso10646-1 medium normal normal 0 nil 100 0 nil>])
> >       internal-set-lisp-face-attribute(region :font "bitstream vera sans 
> > mono-26" 0)
> >       set-face-attribute(region nil :font "bitstream vera sans mono-26")
> >       set-face-font(region "bitstream vera sans mono-26")
> >       eval((set-face-font (quote region) "bitstream vera sans mono-26") nil)
> >       eval-last-sexp-1(nil)
> >       eval-last-sexp(nil)
> >       call-interactively(eval-last-sexp nil nil)
> >       command-execute(eval-last-sexp)
>
> This works fine in the emacs-24 branch, so it is a new error.  I will bisect it 
> soon.
> Changes to xfaces.c is probably it.
>
>         Jan D.