[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#18302: MSYS2 build issues
From: |
Eli Zaretskii |
Subject: |
bug#18302: MSYS2 build issues |
Date: |
Thu, 21 Aug 2014 22:22:36 +0300 |
> Date: Thu, 21 Aug 2014 14:38:13 -0400
> From: Ken Brown <kbrown@cornell.edu>
> CC: chriszheng99@gmail.com, 18302@debbugs.gnu.org
>
> > I'd urge the Cygwin Emacs maintainers to revert that special case, but
> > that's their call. For native Windows builds, I certainly object to
> > introducing this deviation.
>
> The Cygwin situation is not comparable. The headers are installed in
> the standard places. But Cygwin provides two versions of xpm.h, one in
> /usr/include/X11 and one in /usr/include/noX. The Cygwin w32 build
> needs to add -I/usr/include/noX to CPPFLAGS (and -L/usr/lib/noX to
> LDFLAGS) in order to pick up the correct version.
No, the solution is to use
#if defined __CYGWIN__ && !defined HAVE_X_WINDOWS
#include <noX/xpm.h>
#else
#include <xpm.h>
#endif
The way we work around the problem now will break if someone installs
the standard header files in a place other than /usr/include.
And if you disagree, then at least please put the above explanation in
configure.ac, so that we won't need to have this discussion a year
from now.
- bug#18302: MSYS2 build issues, Karol Ostrovsky, 2014/08/20
- bug#18302: MSYS2 build issues, Eli Zaretskii, 2014/08/20
- bug#18302: MSYS2 build issues, Glenn Morris, 2014/08/20
- bug#18302: MSYS2 build issues, Eli Zaretskii, 2014/08/20
- bug#18302: MSYS2 build issues, Karol Ostrovsky, 2014/08/21
- bug#18302: MSYS2 build issues, Eli Zaretskii, 2014/08/21
- bug#18302: MSYS2 build issues, Glenn Morris, 2014/08/21
- bug#18302: MSYS2 build issues, Ken Brown, 2014/08/21
- bug#18302: MSYS2 build issues,
Eli Zaretskii <=
- bug#18302: MSYS2 build issues, Eli Zaretskii, 2014/08/21
- bug#18302: MSYS2 build issues, Ken Brown, 2014/08/21
- bug#18302: MSYS2 build issues, Eli Zaretskii, 2014/08/22
- bug#18302: MSYS2 build issues, Ken Brown, 2014/08/22
- bug#18302: MSYS2 build issues, Eli Zaretskii, 2014/08/22
- bug#18302: MSYS2 build issues, Karol Ostrovsky, 2014/08/22
- bug#18302: MSYS2 build issues, Eli Zaretskii, 2014/08/23
- bug#18302: MSYS2 build issues, Karol Ostrovsky, 2014/08/25
- bug#18302: MSYS2 build issues, Eli Zaretskii, 2014/08/25
bug#18302: MSYS2 build issues, Angelo Graziosi, 2014/08/21