bug#18173: 24.3; message-sendmail-extra-arguments not applied

[Glenn Morris]

Myles English wrote:

> (setq message-sendmail-extra-arguments '("-C"
>       "/home/myles/.config/msmtp/msmtprc"))
>
> But got the error "Sending...failed with exit value 78".
>
> The patch below prevents that error, allows the extra arguments to be
> applied, and thus the config file to be found.

Sorry, I'm being dense, because I cannot see a bug here, or how your
patch makes any difference to anything. Can you explain?

> --- message.el
> +++ message.el
> @@ -4723,9 +4723,7 @@
>               (erase-buffer))))
>         (let* ((default-directory "/")
>                (coding-system-for-write message-send-coding-system)
> -              (cpr (apply
> -                    'call-process-region
> -                    (append
> +              (args (append
>                       (list (point-min) (point-max) sendmail-program
>                             nil errbuf nil "-oi")
>                       message-sendmail-extra-arguments
> @@ -4745,7 +4743,8 @@
>                       ;; For a resend, include the specific addresses.
>                       (if resend-to-addresses
>                           (list resend-to-addresses)
> -                       '("-t"))))))
> +                       '("-t"))))
> +              (cpr (apply 'call-process-region args)))
>           (unless (or (null cpr) (and (numberp cpr) (zerop cpr)))
>                (if errbuf (pop-to-buffer errbuf))
>             (error "Sending...failed with exit value %d" cpr)))