bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19111: 25.0.50; 32 bits temacs.exe is linked with wrong image-base w


From: Eli Zaretskii
Subject: bug#19111: 25.0.50; 32 bits temacs.exe is linked with wrong image-base when built on 64 bit Windows host
Date: Fri, 21 Nov 2014 10:28:17 +0200

> From: Óscar Fuentes <ofv@wanadoo.es>
> Cc: 19111@debbugs.gnu.org, Dani Moncayo <dmoncayo@gmail.com>
> Date: Fri, 21 Nov 2014 01:07:37 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > If the user sets the triplet, it should be obeyed.  If it's incorrect,
> > that's the user's problem.
> >
> >> I understand your concern: `configure' can use the triplet anywhere and
> >> hence it is important that it is correct.
> >
> > Yes, exactly.
> >
> > Could you propose a patch along these lines?
> 
> Something like this, perhaps? (It should also work for Dani's Cygwin
> case.)

Yes, thanks.

> +      t=${t#Target: }

Is this portable to Unix shells?  If not, perhaps use the 'eval' trick
here.

> +      if test "x$t" = "x"; then
> +       AC_MSG_ERROR([Impossible to determine $cc compiler target.
> +Please explicitly provide --target])

I would replace this with a warning and go with $canonical as it was
determined before.

Otherwise, I think this is good to go in, but please wait for a couple
of days to let others comment if they want.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]