bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19117: 25.0.50; emacs on x11 chooses different fonts for the same fa


From: Jan D.
Subject: bug#19117: 25.0.50; emacs on x11 chooses different fonts for the same face sometimes
Date: Thu, 05 Feb 2015 16:08:52 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

Stefan Monnier skrev den 2015-02-03 18:53:
This is a gentle ping. Is there anything more I can do to get this
merged?

I could install it, but I really have no idea whether your patch does
the right thing, because I'm too unfamiliar with this code.
Jan?  Handa?


The patch looks bigger than it is because lot of the diff is just increased indentation. I guess it looks OK. These old fonts are deprecated anyway, so if it does the right thing for the OP, I guess we can install it.

But the comment here:

+          /* We skip the second pass unless we really need it.  */
+ if (!(NILP (list) /* No fonts found on the first pass */ + && skipped_some_scalable_fonts)) /* and we skipped some scalable ones. */
+            break;


looks like it really should be  /* Fonts found on the first pass */

        Jan D.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]