bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19909: [PATCH] Error out if with-file-notification=w32 is specified


From: Ken Brown
Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin
Date: Fri, 27 Feb 2015 17:25:54 -0500
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 2/20/2015 12:18 PM, Eli Zaretskii wrote:
Date: Fri, 20 Feb 2015 11:15:18 -0500
From: Ken Brown <kbrown@cornell.edu>
CC: bug-gnu-emacs@gnu.org, Robert Pluim <rpluim@gmail.com>

I'm busy with other things at the moment and can't get to it right away.
   If it's easy for you to suggest a patch, why don't you go ahead, and
Robert can test it.  Or you can wait a couple weeks until I can look at it.

OK, I will try to find time.

BTW, file-notification=gfile works fine in the Cygwin-w32 build, so I'm
not sure there's any need to put a lot of effort into this.

If it turns out to need a lot of effort, I'll agree with you.

It looks like it might not take much effort. What I did for now, just for testing purposes, is to copy into w32notify.c whatever was necessary to make the Cygwin-w32 build compile with w32 file notification. I tested it briefly and it seems to work. Obviously it needs much more testing to make sure this doesn't break anything else, and then we can worry about how to do this right.

Robert, please test when you get a chance (patch attached).

Ken

Attachment: cygw32_notify.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]