[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20608: 25.0.50; vc-git-log-view-mode inserts "Show 2X entries" at bo
From: |
Stefan Monnier |
Subject: |
bug#20608: 25.0.50; vc-git-log-view-mode inserts "Show 2X entries" at bob when interrupted |
Date: |
Sun, 24 May 2015 22:57:22 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
> See the window shrink and "Show 2X entries Show unlimited entries"
> appear at the top (it will also get added at the bottom when the process
> finishes).
> It seems like a general problem, to be fixed either in vc-do-command (by
> unsetting the process sentinel before deleting the process), or in
> vc--process-sentinel. Here's the patch for the second option:
Could it be that the problem is that in vc-do-command we first do
(unless (or (eq buffer t)
(and (stringp buffer)
(string= (buffer-name) buffer))
(eq buffer (current-buffer)))
(vc-setup-buffer buffer))
and only afterwards do we do
(let ((oldproc (get-buffer-process (current-buffer))))
;; If we wanted to wait for oldproc to finish before doing
;; something, we'd have used vc-eval-after.
;; Use `delete-process' rather than `kill-process' because we don't
;; want any of its output to appear from now on.
(when oldproc (delete-process oldproc)))
?
-- Stefan