[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20843: 24.5; Profiler error: "Invalid sampling interval"
From: |
Eli Zaretskii |
Subject: |
bug#20843: 24.5; Profiler error: "Invalid sampling interval" |
Date: |
Mon, 22 Jun 2015 18:35:49 +0300 |
> Date: Sun, 21 Jun 2015 18:17:27 -0400
> From: Ken Brown <kbrown@cornell.edu>
> CC: sva-news@mygooglest.com, 20843@debbugs.gnu.org
>
> > If so, we cannot test this at
> > configure time, because it means we will have to run a program, which
> > is not a good idea.
> >
> > So in that case, I think we should simply disable the CPU profiler on
> > Cygwin using "#ifndef __CYGWIN__" or some such.
>
> Done as commit 5fac0de.
Thanks.
> >>> Also, the diagnostics should be improved, as the
> >>> wording is misleading in that case.
> >>
> >> As it stands, profiler-cpu-start reports "Invalid sampling interval"
> >> whenever setup_cpu_timer fails to start the timer, regardless of the
> >> reason. I'll try to improve this.
> >
> > Yes, please.
>
> How's this:
Looks fine, but perhaps it would be cleaner to return the actual
message string or some distinctive code from setup_cpu_timer. This
would avoid the need for a global variable.
Thanks.
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", (continued)
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Ken Brown, 2015/06/20
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Eli Zaretskii, 2015/06/21
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Ken Brown, 2015/06/21
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Sebastien Vauban, 2015/06/22
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Ken Brown, 2015/06/22
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Eli Zaretskii, 2015/06/22
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Ken Brown, 2015/06/22
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Ken Brown, 2015/06/22
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Sebastien Vauban, 2015/06/23
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Ken Brown, 2015/06/23
- bug#20843: 24.5; Profiler error: "Invalid sampling interval",
Eli Zaretskii <=
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Ken Brown, 2015/06/22
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Eli Zaretskii, 2015/06/22
- bug#20843: 24.5; Profiler error: "Invalid sampling interval", Ken Brown, 2015/06/22