bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21496: 25.0.50; guile-file compilation-error regexp is too wide


From: Jostein Kjønigsen
Subject: bug#21496: 25.0.50; guile-file compilation-error regexp is too wide
Date: Sun, 20 Sep 2015 09:44:07 +0200

Since we haven't heard from Jan since this error was first reported,
attached is my patch to have the issue resolved.

Please let me know if this is an acceptable solution, and if anything
more is required on my part.

--
Jostein Kjønigsen
jostein@kjonigsen.net / jostein@secure.kjonigsen.net


On Thu, Sep 17, 2015, at 12:00 AM, Jostein Kjønigsen wrote:
> If I get to have say in this, I think the simplest approach is probably
> the best one: just look for the right extension.
> 
> Jan: Any objections?
> 
> On 16 Sep 2015 23:52, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> 
>>>       In csharp--at-vsemi-p:
>> [...]
>>> The problem is that all these headers are picked up by the guile-file
>>> compilation-error-regexp entry which is extremely wide:
>> 
>>>      (guile-file "^In \\(.+\\):\n" 1)
>> 
>> I was thinking of the patch below, which does two things:
>> 1- lower the importance of those "In blabla:" from "error" to "info".
>> 2- limit the .* to be either something that ends in .scm, or something
>>    that has a slash (or backslash for w32), or something without spaces.
>> 
>> But I see that "something without spaces" is not strict enough, so we
>> should drop it.  Maybe "something that ends in .scm" is good enough?
>> 
>> 
>>         Stefan
>> 
>> 
>> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
>> index a6e9ed8..24b7e63 100644
>> --- a/lisp/progmodes/compile.el
>> +++ b/lisp/progmodes/compile.el
>> @@ -477,7 +477,11 @@ File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = 
>> \\([0-9]+\\)\\)?"
>>       ;;
>>       "^\\([^ \t\r\n(]+\\) (\\([0-9]+\\):\\([0-9]+\\)) "
>>       1 2 3)
>> -    (guile-file "^In \\(.+\\):\n" 1)
>> +    (guile-file
>> +     ;; Try to make sure it's a file name so as not to match unrelated
>> +     ;; text such as "In end of data" or "In top level form" (bug#21496).
>> +     "^In \\(.+\\.scm\\|.+[/\\].*\\|[^ \n\t]+\\):\n"
>> +     1 nil nil 0)
>>      (guile-line "^ *\\([0-9]+\\): *\\([0-9]+\\)" nil 1 2)
>>      )
>>    "Alist of values for `compilation-error-regexp-alist'.")

Attachment: Emacs-compilation-mode-fixes.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]