[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20032: eww: access bookmarks right from the URI prompt
From: |
Lars Ingebrigtsen |
Subject: |
bug#20032: eww: access bookmarks right from the URI prompt |
Date: |
Fri, 25 Dec 2015 07:35:16 +0100 |
User-agent: |
Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) |
Ivan Shmakov <ivan@siamics.net> writes:
> Please consider the revised patch MIMEd.
>
> * lisp/net/eww.el (eww-suggest-uris): Add eww-suggest-bookmarks
> to the default value and :options. (Bug#20032)
> (eww-suggested-bookmarks-annotation): New customizable variable.
> (eww-suggest-bookmarks, eww-remove-annotation)
> (eww-substring-nil-property): New functions.
> (eww-suggested-uris, eww): Use eww-remove-annotation.
I get a compilation warning after applying the patch... (The defvar for
eww-bookmarks should be moved.)
But conceptually I'm not sure this is a good idea. If you have a
bookmarks file, then if you say `M-x eww', you will apparently default
to the first entry in the bookmarks file? That doesn't seem very
helpful. It would be OK to have that as the first entry in the `M-n'
history, but not as the default. If I read the code correctly.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no