bug#12394: 24.2.50; wdired: error when wdired-use-interactive-rename is non-nil

[martin rudalics]

>> In general, IMHO `wdired-use-interactive-rename' is not very useful at
>> all.  I never used it, and the fact that all these problems were never
>> reported by anyone before indicates that not many people are using it.
>>
>> I suggest to remove it completely.

IIUC this was broken by the introduction of the 'dired-filename' text
property.  There's hardly anything reasonable we can do about this.
That property should be front-sticky but wdired removes all text
properties it creates before doing the renaming so this seems hardly
reliable.

So we probably should obsolete ‘wdired-use-interactive-rename’ and not
call ‘wdired-search-and-rename’ any more in ‘wdired-do-renames’ in the
Emacs-25 branch.

>> Instead, it would be better to
>> ask the user in a way similar to e.g. C in dired, like
>>
>> Really perform these renamings?
>>
>> a -> b
>> b -> a
>> file-x -> file-y
>> ...
>>
>> But I'm open to other suggestions.  Any opinions?
>
> +1.

Sounds TRT to me too.

martin