[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy pro
From: |
Lars Magne Ingebrigtsen |
Subject: |
bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly |
Date: |
Sun, 20 Mar 2016 12:21:09 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Tao Fang <fangtao0901@gmail.com> writes:
> I've received notice email of the assignment/disclaimer process with the
> FSF yesterday, and currently it's complete, please check the file to see
> if it's all okay?
Your assignment is now on file...
> And I've re-format the previous attached patch file and maybe somebody
> could helping review, modify and apply it to the repo?
Looks basically good, but a few notes:
> - (let ((proc (url-open-stream host buf host port gateway-method)))
> + (let ((proc (url-open-stream host buf
> + (if url-using-proxy (url-host
> url-using-proxy) host)
> + (if url-using-proxy (url-port
> url-using-proxy) port)
> + gateway-method)))
Throughout the code, the lines seem to be too long. They should
preferably not be more than 80 characters long (unless there's an
absolute need).
[...]
> + (let ((tls-connection (gnutls-negotiate
> + :process proc
> + :hostname (url-host
> url-current-object)
> + :verify-error nil)))
After negotiation, you should probably call `nsm-verify-connection'.
Uhm... and that's it. Oh, and a NEWS entry saying that url now
supports HTTPS proxies would be nice, and a ChangeLog style commit
message.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no